[virglrenderer-devel] [PATCH v2 21/21] configure.ac: Add more warning flags

[Gurchetan Singh]

On Tue, Jun 5, 2018 at 1:12 PM Gert Wollny <gert.wollny at collabora.com> wrote:
>
> Signed-off-by: Gert Wollny <gert.wollny at collabora.com>
> ---
>  configure.ac | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/configure.ac b/configure.ac
> index b719188..24131b7 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -29,9 +29,11 @@ AC_CHECK_PROGS([PYTHON], [python2 python python3])
>  AX_CODE_COVERAGE
>
>  AX_CHECK_COMPILE_FLAG([-Wall],                                 [CFLAGS="$CFLAGS -Wall"])
> +AX_CHECK_COMPILE_FLAG([-Wextra],                               [CFLAGS="$CFLAGS -Wextra"])
>  AX_CHECK_COMPILE_FLAG([-Werror=implicit-function-declaration], [CFLAGS="$CFLAGS -Werror=implicit-function-declaration"])
>  AX_CHECK_COMPILE_FLAG([-Werror=missing-prototypes],            [CFLAGS="$CFLAGS -Werror=missing-prototypes"])
>  AX_CHECK_COMPILE_FLAG([-Wmissing-prototypes],                  [CFLAGS="$CFLAGS -Wmissing-prototypes"])
> +AX_CHECK_COMPILE_FLAG([-Wint-to-pointer-cast],                 [CFLAGS="$CFLAGS -Werror=int-to-pointer-cast"])

Don't you want

AX_CHECK_COMPILE_FLAG([-Werror=int-to-pointer-cast],
[CFLAGS="$CFLAGS -Werror=int-to-pointer-cast"])

??  Maybe we should turn on -Werror for all warnings.

>
>  AC_MSG_CHECKING([for native Win32])
>  case "$host_os" in
> --
> 2.16.4
>
> _______________________________________________
> virglrenderer-devel mailing list
> virglrenderer-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/virglrenderer-devel