[virglrenderer-devel] [PATCH v2 21/21] configure.ac: Add more warning flags

[Gert Wollny]

Am Dienstag, den 05.06.2018, 17:47 -0700 schrieb Gurchetan Singh:
> On Tue, Jun 5, 2018 at 1:12 PM Gert Wollny <gert.wollny at collabora.com
> > wrote:
> > 
> > Signed-off-by: Gert Wollny <gert.wollny at collabora.com>
> > ---
> >  configure.ac | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index b719188..24131b7 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -29,9 +29,11 @@ AC_CHECK_PROGS([PYTHON], [python2 python
> > python3])
> >  AX_CODE_COVERAGE
> > 
> >  AX_CHECK_COMPILE_FLAG([-
> > Wall],                                 [CFLAGS="$CFLAGS -Wall"])
> > +AX_CHECK_COMPILE_FLAG([-
> > Wextra],                               [CFLAGS="$CFLAGS -Wextra"])
> >  AX_CHECK_COMPILE_FLAG([-Werror=implicit-function-declaration],
> > [CFLAGS="$CFLAGS -Werror=implicit-function-declaration"])
> >  AX_CHECK_COMPILE_FLAG([-Werror=missing-
> > prototypes],            [CFLAGS="$CFLAGS -Werror=missing-
> > prototypes"])
> >  AX_CHECK_COMPILE_FLAG([-Wmissing-
> > prototypes],                  [CFLAGS="$CFLAGS -Wmissing-
> > prototypes"])
> > +AX_CHECK_COMPILE_FLAG([-Wint-to-pointer-
> > cast],                 [CFLAGS="$CFLAGS -Werror=int-to-pointer-
> > cast"])
> 
> Don't you want
> 
> AX_CHECK_COMPILE_FLAG([-Werror=int-to-pointer-cast],
> [CFLAGS="$CFLAGS -Werror=int-to-pointer-cast"])
You're right (although I assume that if a warning exists the
corresponding -Werror= flag also exists),  I'll send an update shortly.

> ??  Maybe we should turn on -Werror for all warnings.
I don't think this is a good idea. New compilers introduce new warnings
and sometimes one also gets warnings from third party header files, and
we can't tests all of these cases. 

Best, 
Gert