[virglrenderer-devel] [PATCH 3/3] vrend_shader: add arb_gpu_shader_fp64 support

Gurchetan Singh gurchetansingh at chromium.org
Fri Jun 8 02:01:35 UTC 2018


Patches 1 and 2 are:

Reviewed-by: Gurchetan Singh <gurchetansingh at chromium.org>

It sounds like we can remove fp64_srcs (maybe even fp64_dsts and do
conversions on the fly?!) in patch 3, so   On Thu, Jun 7, 2018 at 6:41
PM Dave Airlie <airlied at gmail.com> wrote:
>
> On 5 June 2018 at 14:43, Dave Airlie <airlied at gmail.com> wrote:
> > On 5 June 2018 at 06:10, Dave Airlie <airlied at gmail.com> wrote:
> >> On 5 June 2018 at 05:59, Gurchetan Singh <gurchetansingh at chromium.org> wrote:
> >>> Which commands are you using to test this?  Every fp64 Piglit test I run is
> >>> skipped (though I am a Piglit newbie):
> >>>
> >>> ~/piglit$ ./bin/arb_gpu_shader_fp64-tf-interleaved-aligned
> >>> libGL error: MESA-LOADER: failed to retrieve device information
> >>> MESA-LOADER: failed to retrieve device information
> >>> MESA-LOADER: failed to retrieve device information
> >>> Test requires GL_ARB_gpu_shader_fp64
> >>> PIGLIT: {"result": "skip" }
> >>>
> >>> Are there any guest side changes also needed?
> >>
> >> Oh sorry there is one mesa patch to enable doubles.
> >>
> >> https://cgit.freedesktop.org/~airlied/mesa/commit/?h=virgl-fp64&id=f47a495868a741a5263e259d01ba127a48bf9181
> >>
> >> rebased onto master, I should send that out as well.
> >
> >
> > I've sent the mesa side patch to the mesa list.
> >
> > https://patchwork.freedesktop.org/series/44240/
>
> ping?
>
> (note I'm not too pushed about the fp64 bits, but I'd like to get the
> refactoring patches in at least).
>
> Dave.


More information about the virglrenderer-devel mailing list