[virglrenderer-devel] [PATCH] renderer: remove the extra block in fb_bind_texture()

Gurchetan Singh gurchetansingh at chromium.org
Fri Jun 15 22:52:03 UTC 2018


On Fri, Jun 15, 2018 at 11:19 AM <ramin.azarmehr at gmail.com> wrote:

> From: Ramin Azarmehr <ramin.azarmehr at gmail.com>
>
> ---
>  src/vrend_renderer.c | 17 ++++++++---------
>  1 file changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/src/vrend_renderer.c b/src/vrend_renderer.c
> index 8b0a1e0..141fa18 100644
> --- a/src/vrend_renderer.c
> +++ b/src/vrend_renderer.c
> @@ -1466,15 +1466,14 @@ void vrend_fb_bind_texture(struct vrend_resource
> *res,
>     const struct util_format_description *desc =
> util_format_description(res->base.format);
>     GLenum attachment = GL_COLOR_ATTACHMENT0_EXT + idx;
>
> -   if (vrend_format_is_ds(res->base.format)) { {
> -         if (util_format_has_stencil(desc)) {
> -            if (util_format_has_depth(desc))
> -               attachment = GL_DEPTH_STENCIL_ATTACHMENT;
> -            else
> -               attachment = GL_STENCIL_ATTACHMENT;
> -         } else
> -            attachment = GL_DEPTH_ATTACHMENT;
> -      }
> +   if (vrend_format_is_ds(res->base.format)) {
> +      if (util_format_has_stencil(desc)) {
> +         if (util_format_has_depth(desc))
> +            attachment = GL_DEPTH_STENCIL_ATTACHMENT;
> +         else
> +            attachment = GL_STENCIL_ATTACHMENT;
> +      } else
> +         attachment = GL_DEPTH_ATTACHMENT;
>     }
>

Reviewed-by: Gurchetan Singh <gurchetansingh at chromium.org>



>
>     switch (res->target) {
> --
> 2.17.1
>
> _______________________________________________
> virglrenderer-devel mailing list
> virglrenderer-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/virglrenderer-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/virglrenderer-devel/attachments/20180615/9e8cf4b1/attachment.html>


More information about the virglrenderer-devel mailing list