[virglrenderer-devel] [PATCH 0/4] Enable GLES3 on GLES hosts

[Gurchetan Singh]

Fair enough, if the caps code separates by feature, we shouldn't need to
clump everything together in one "if (gles_ver >= 30)" block.
On Wed, May 16, 2018 at 1:14 PM Jakob Bornecrantz <jakob at collabora.com>
wrote:

> Thanks for the review!

> With regards to merging the "if (gles_ver >= 30)" blocks. In the other
> caps code they are separated by feature instead of gl version, so this
> is more in line with the other code. Also should we find that there is a
> extension for a certain feature and not just GLES version we can only
> set a feature at one place.

> Cheers, Jakob.

> On 2018-05-16 18:41, Gurchetan Singh wrote:
> > Looks good.  One minor issue:
> >
> > For "Add GL_ARB_uniform_buffer_object for gles" and "Add
> > GL_EXT_transform_feedback for gles", can put the new code in the "if
> > (gles_ver >= 30)" statement we use for GL_MAX_ARRAY_TEXTURE_LAYERS?  You
> > may have to rebase with Tomeu's patch too.
> >
> > With that, the series is:
> > Reviewed-by: Gurchetan Singh <gurchetansingh at chromium.org>
> >
> >> Hello list!
> >
> >> This patch series enables you to run GLES3 on a GLES host. Some of
these
> >> patches may have been sent out before but no real changes has been made
> > since
> >> then.
> >
> >> They cause three "regressions" in GLES2, I have tracked it down to the
> > shader
> >> level commit. But these test fail on Intel host Desktop GL as well so
once
> >> those tests has been fix there they will be fixed her as well.
> >
> >> They are based on my two general fixes and Tomeu's GLES3 fixes. Patches
> > also
> >> available on the proposed-for-upstream branch here:
> >> https://gitlab.collabora.com/virgl-es/virglrenderer
proposed-for-upstream
> >
> >> Cheers, Jakob.
> >
> >> Jakob Bornecrantz (4):
> >>      vrend: Add VIRGL_FORMAT_R8G8B8A8_SRGB format and test for more
sRGB
> >>        formats
> >>      vrend: Add GL_ARB_uniform_buffer_object for gles
> >>      vrend: Add GL_EXT_transform_feedback for gles
> >>      vrend: Up the shader feature level when on GLES 3.x
> >
> >>     src/virgl_hw.h       |  1 +
> >>     src/vrend_formats.c  |  2 +-
> >>     src/vrend_renderer.c | 25 +++++++++++++++++++++++--
> >>     3 files changed, 25 insertions(+), 3 deletions(-)
> >
> >> --
> >> 2.14.1
> >
> >> _______________________________________________
> >> virglrenderer-devel mailing list
> >> virglrenderer-devel at lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/virglrenderer-devel
> > _______________________________________________
> > virglrenderer-devel mailing list
> > virglrenderer-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/virglrenderer-devel
> >