[virglrenderer-devel] [PATCH] vrend: enable multisample on GLE host with GLES >= 3.0

[Gurchetan Singh]

Reviewed-by: Gurchetan Singh <gurchetansingh at chromium.org>


On Thu, May 17, 2018 at 9:29 AM Gert Wollny <gert.wollny at collabora.com>
wrote:

> Multisample fragment operations are part of the OpenGL ES 3.0 spec and
> enabling them doesnt't required the extensions to be listed explicitely.
>
> Fixes:
>
>
>  dEQP-GLES3.functional.multisample.fbo_max_samples.proportionality_alpha_to_coverage
>
>  dEQP-GLES3.functional.multisample.fbo_max_samples.proportionality_sample_coverage
>
>  dEQP-GLES3.functional.multisample.fbo_max_samples.proportionality_sample_coverage_inverted
>  dEQP-GLES3.functional.multisample.fbo_max_samples.sample_coverage_invert
>
> on an GLE host with GLES >= 3.0.
>
> Signed-off-by: Gert Wollny <gert.wollny at collabora.com>
> ---
>  src/vrend_renderer.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/vrend_renderer.c b/src/vrend_renderer.c
> index 6fd8a63..fd7eb77 100644
> --- a/src/vrend_renderer.c
> +++ b/src/vrend_renderer.c
> @@ -4216,7 +4216,9 @@ int vrend_renderer_init(struct vrend_if_cbs *cbs,
> uint32_t flags)
>
>     if (epoxy_has_gl_extension("GL_ARB_stencil_texturing"))
>        vrend_state.have_stencil_texturing = true;
> -   if (epoxy_has_gl_extension("GL_EXT_framebuffer_multisample") &&
> epoxy_has_gl_extension("GL_ARB_texture_multisample")) {
> +   if ((gles && gl_ver >= 30) ||
> +       (epoxy_has_gl_extension("GL_EXT_framebuffer_multisample") &&
> +        epoxy_has_gl_extension("GL_ARB_texture_multisample"))) {
>        vrend_state.have_multisample = true;
>        if
> (epoxy_has_gl_extension("GL_EXT_framebuffer_multisample_blit_scaled"))
>           vrend_state.have_ms_scaled_blit = true;
> --
> 2.16.1
>
> _______________________________________________
> virglrenderer-devel mailing list
> virglrenderer-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/virglrenderer-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/virglrenderer-devel/attachments/20180517/dcef12df/attachment.html>