[virglrenderer-devel] [PATCH] vrend: enable multisample on GLE host with GLES >= 3.0

[Gert Wollny]

Am Donnerstag, den 17.05.2018, 20:31 -0700 schrieb Gurchetan Singh:
> Reviewed-by: Gurchetan Singh <gurchetansingh at chromium.org>
> 
Thanks for the review, but pleas don't push it yet, I'm investigating
possible regressions. 

Best, 
Gert 

> 
> On Thu, May 17, 2018 at 9:29 AM Gert Wollny <gert.wollny at collabora.co
> m> wrote:
> > Multisample fragment operations are part of the OpenGL ES 3.0 spec
> > and
> > enabling them doesnt't required the extensions to be listed
> > explicitely.
> > 
> > Fixes:
> > 
> >  dEQP-
> > GLES3.functional.multisample.fbo_max_samples.proportionality_alpha_
> > to_coverage
> >  dEQP-
> > GLES3.functional.multisample.fbo_max_samples.proportionality_sample
> > _coverage
> >  dEQP-
> > GLES3.functional.multisample.fbo_max_samples.proportionality_sample
> > _coverage_inverted
> >  dEQP-
> > GLES3.functional.multisample.fbo_max_samples.sample_coverage_invert
> > 
> > on an GLE host with GLES >= 3.0.
> > 
> > Signed-off-by: Gert Wollny <gert.wollny at collabora.com>
> > ---
> >  src/vrend_renderer.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/src/vrend_renderer.c b/src/vrend_renderer.c
> > index 6fd8a63..fd7eb77 100644
> > --- a/src/vrend_renderer.c
> > +++ b/src/vrend_renderer.c
> > @@ -4216,7 +4216,9 @@ int vrend_renderer_init(struct vrend_if_cbs
> > *cbs, uint32_t flags)
> > 
> >     if (epoxy_has_gl_extension("GL_ARB_stencil_texturing"))
> >        vrend_state.have_stencil_texturing = true;
> > -   if (epoxy_has_gl_extension("GL_EXT_framebuffer_multisample") &&
> > epoxy_has_gl_extension("GL_ARB_texture_multisample")) {
> > +   if ((gles && gl_ver >= 30) ||
> > +       (epoxy_has_gl_extension("GL_EXT_framebuffer_multisample")
> > &&
> > +        epoxy_has_gl_extension("GL_ARB_texture_multisample"))) {
> >        vrend_state.have_multisample = true;
> >        if
> > (epoxy_has_gl_extension("GL_EXT_framebuffer_multisample_blit_scaled
> > "))
> >           vrend_state.have_ms_scaled_blit = true;
> > _______________________________________________
> > virglrenderer-devel mailing list
> > virglrenderer-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/virglrenderer-devel