[virglrenderer-devel] [PATCH] virgl: set texture buffer offset alignment to disable ARB_texture_buffer_range.

Gurchetan Singh gurchetansingh at chromium.org
Fri May 18 15:51:43 UTC 2018


Reviewed-by: Gurchetan Singh <gurchetansingh at chromium.org>


On Fri, May 18, 2018 at 6:01 AM Elie Tournier <tournier.elie at gmail.com>
wrote:

> Wrong ML. I add <mesa-dev at lists.freedesktop.org>
>
> On Fri, May 18, 2018 at 10:46:29AM +1000, Dave Airlie wrote:
> > From: Dave Airlie <airlied at redhat.com>
> >
> > The host side hasn't got support for this feature yet, so don't enable it
> > unless we get the caps from the host.
> >
> > This makes the texture buffer range piglit tests skip now.
> >
> > Fixes: fe0647df5a7 (virgl: add offset alignment values to to v2 caps
> struct)
> Acked-by: Elie Tournier <elie.tournier at collabora.com>
> > ---
> >  src/gallium/drivers/virgl/virgl_winsys.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/gallium/drivers/virgl/virgl_winsys.h
> b/src/gallium/drivers/virgl/virgl_winsys.h
> > index 99e98ad9c9c..690e610e199 100644
> > --- a/src/gallium/drivers/virgl/virgl_winsys.h
> > +++ b/src/gallium/drivers/virgl/virgl_winsys.h
> > @@ -132,7 +132,7 @@ static inline void
> virgl_ws_fill_new_caps_defaults(struct virgl_drm_caps *caps)
> >     caps->caps.v2.max_texel_offset = 7;
> >     caps->caps.v2.min_texture_gather_offset = -8;
> >     caps->caps.v2.max_texture_gather_offset = 7;
> > -   caps->caps.v2.texture_buffer_offset_alignment = 32;
> > +   caps->caps.v2.texture_buffer_offset_alignment = 0;
> >     caps->caps.v2.uniform_buffer_offset_alignment = 256;
> >  }
> >  #endif
> > --
> > 2.14.3
> >
> > _______________________________________________
> > virglrenderer-devel mailing list
> > virglrenderer-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/virglrenderer-devel
> _______________________________________________
> virglrenderer-devel mailing list
> virglrenderer-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/virglrenderer-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/virglrenderer-devel/attachments/20180518/bfb8c2ac/attachment-0001.html>


More information about the virglrenderer-devel mailing list