[virglrenderer-devel] [PATCH] vrend_renderer: remove should_invert_viewport

Gert Wollny gert.wollny at collabora.com
Mon May 28 09:40:23 UTC 2018


Reviewed-By: Gert Wollny <gert.wollny at collabora.com>

Am Freitag, den 25.05.2018, 17:08 -0700 schrieb Gurchetan Singh:
> It's an unused function.
> ---
>  src/vrend_renderer.c | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/src/vrend_renderer.c b/src/vrend_renderer.c
> index df575b1..683804e 100644
> --- a/src/vrend_renderer.c
> +++ b/src/vrend_renderer.c
> @@ -542,17 +542,6 @@ static void __report_gles_missing_func(const
> char *fname, struct vrend_context *
>  }
>  #define report_gles_missing_func(ctx, missf)
> __report_gles_missing_func(__func__, ctx, missf)
>  
> -
> -static inline bool should_invert_viewport(struct vrend_context *ctx)
> -{
> -   /* if we have a negative viewport then gallium wanted to invert
> it,
> -      however since we are rendering to GL FBOs we need to invert it
> -      again unless we are rendering upside down already
> -      - confused?
> -      so if gallium asks for a negative viewport */
> -   return !(ctx->sub->viewport_is_negative ^ ctx->sub-
> >inverted_fbo_content);
> -}
> -
>  static void vrend_destroy_surface(struct vrend_surface *surf)
>  {
>     vrend_resource_reference(&surf->texture, NULL);


More information about the virglrenderer-devel mailing list