[virglrenderer-devel] [PATCH 2/3] vrend: Support GL blits for multisample textures

Alexandros Frantzis alexandros.frantzis at collabora.com
Wed May 30 14:47:24 UTC 2018


On Wed, May 30, 2018 at 12:04:34PM +0200, Gert Wollny wrote:
> There is little problem I came across rebasing to the lastest upstream 
> 
> Am Freitag, den 25.05.2018, 16:51 +0300 schrieb Alexandros Frantzis:
> > Update the GL blit code to support blitting for multisample textures,
> > for both normalized and integer color formats.
> > 
> [...]
> > +
> > +   if (swizzle)
> > +      create_dest_swizzle_snippet(swizzle, dest_swizzle_snippet);
> > +
> > +   snprintf(shader_buf, 4096,
> > +            blit_ctx->use_gles ? FS_TEXFETCH_COL_MSAA_GLES :
> > FS_TEXFETCH_COL_MSAA_GL,
> > +            ext_str, vec4_type_for_tgsi_ret(tgsi_ret),
> > +            vrend_shader_samplerreturnconv(tgsi_ret),
> Dave made this function static with e95aa50ca4, so you will need add
> another patch against vrend_shader.c to make is visible again.
> 
> [...]
> 
> best, 
> Gert 
> 

Hi Gert,

the first patch in the series ([1], see near end of patch), makes this
function public again and uses it in the blitter code. If that's not
clear/obvious enough, I could split out that vrend_shader change to a
separate commit.

Thanks,
Alexandros

[1] https://patchwork.freedesktop.org/patch/225485/


More information about the virglrenderer-devel mailing list