[virglrenderer-devel] reviewing merge requests

[Gurchetan Singh]

On Wed, Apr 10, 2019 at 12:28 AM Gert Wollny <gert.wollny at collabora.com>
wrote:

> Hi all,
>
> since Dave promoted me to maintainer I'm now try to take a look to see
> what MRs can be merged, but sometimes it is just inconvenient to do
> this every day, so I'd like to I ask the following favours to make
> things more smooth:
>
> * When you submit MRs, please enable the CI, I prefer to merge using
>   "Merge when pipeline passes"
>

How does one enable the CI?  It's not one of the options when editing a
merge requests.

Note with Mesa, Gitlab shows the "Merge when pipeline passes" option for
me, while virglrenderer only shows "Merge" option.


>
> * After doing a review please tag the MR with one of
>    - is-reviewed,
>    - waiting for changes, or
>    - needs more reviews
>   with that I can see the state of a MR without digging through the
>   comments or through all the emails.


Developer access atleast is needed to add tags, I believe.  I created a
test account and issued a new merge request it:

https://gitlab.freedesktop.org/virgl/virglrenderer/merge_requests/219

Unfortunately, I couldn't edit the tags.


>
>
> * when you've done a review and you add the RB-tag
>   - could you pleaseformat the tag as code for easy copy-and-paste?
>
> * When you got a review on your own MR and have time, then it is nice
>   if you could add the R-B tags to the commit messages and add the tag
>   - rb-tags added
>
> * When you have Developer state,
>   - when you git a review, don't wait for me to merge your own on MRs,
>     Me or Dave will probably eventually do it, but  but it's faster if
>     you do it yourself,
>   - if you reviewed a MR by someone who can't merge, feel free to merge
>     it yourself,
>   - using the "Merge when  pipeline passes" button is preferred
>
> Many thanks,
> Gert
> _______________________________________________
> virglrenderer-devel mailing list
> virglrenderer-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/virglrenderer-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/virglrenderer-devel/attachments/20190410/b1938c61/attachment.html>