[virglrenderer-devel] reviewing merge requests

[Gert Wollny]

Hello Gurchetan, 

Am Mittwoch, den 10.04.2019, 10:44 -0700 schrieb Gurchetan Singh:
> 
> 
> 
> How does one enable the CI?  It's not one of the options when editing
> a merge requests.
I'll add this to the wiki. The CI file must be set for the fork you're
using: 

  Settings/CI 
    General pipelines
    
   Timeout: 2h 
   Custom CI config path: ci/.gitlab-ci.yml  
   
Currently the CI is only building and running "make check" for normal
commits, and only for merge requests the full test series is run. 

> Note with Mesa, Gitlab shows the "Merge when pipeline passes" option
> for me, while virglrenderer only shows "Merge" option.
This is when you didn't set up the CI for your fork. For security
reasons gitlab doesn't allow to run the CI of a merge requests in the
main repo space.  

>  
> > * After doing a review please tag the MR with one of 
> >    - is-reviewed,
> >    - waiting for changes, or  
> >    - needs more reviews
> >   with that I can see the state of a MR without digging through
> > the 
> >   comments or through all the emails. 
> 
> Developer access atleast is needed to add tags, I believe.  I created
> a test account and issued a new merge request it:
> 
> https://gitlab.freedesktop.org/virgl/virglrenderer/merge_requests/219
> 
> Unfortunately, I couldn't edit the tags.
I think it's reporter status that is needed. I'll added Lepton Wu and
Pohsien Wang. 

I've also put this on a wiki page: 
https://gitlab.freedesktop.org/virgl/virglrenderer/wikis/Merge-requests

Best, 
Gert