[waffle] [PATCH] cmake: Fix dependency on cmocka

Chad Versace chad.versace at linux.intel.com
Mon Dec 2 15:00:51 PST 2013


On 12/02/2013 02:53 PM, Paul Berry wrote:
> On 2 December 2013 14:46, Chad Versace <chad.versace at linux.intel.com> wrote:
>
>> This fixes an error in the Makefile-dependency of unittests, introduced
>> in commit ad40427a864a7436953b319fbfdb2c04ccb7bdab.
>>
>>  From the perspective of Waffle's CMake, libcmocka.so is an *imported*
>> library. In other words, it's a virtual target, represented by
>> a '.PHONY' target in Unix Makefiles.
>>
>> To guarantee that libcmocka.so gets built, CMake must declare that the
>> .PHONY 'cmocka' target depends on another .PHONY target, which does the
>> actual building. Making 'cmocka' depend on a non-PHONY target doesn't
>> work.
>>
>> Reported-by: Shazia Rahman <srahman at nvidia.com>
>> Reported-by: Paul Berry <stereotype441 at gmail.com>
>> Signed-off-by: Chad Versace <chad.versace at linux.intel.com>
>>
>
> That fixes the problem for me, thanks!
>
> Tested-by: Paul Berry <stereotype441 at gmail.com>

Thanks, committed.

Hopefully this fixes Shazia's problem too.



More information about the waffle mailing list