[waffle] [PATCH] cmake: Fix dependency on cmocka

[Shazia Rahman]

Hi,
If I do 'git rebase origin/master' and then do a make clean and run make I should not see that error again, right?
I'm not that familiar with git, can you please help me in applying this change to my local tree.
Do I need to sync to some other branch? 


> -----Original Message-----
> From: Chad Versace [mailto:chad.versace at linux.intel.com]
> Sent: Tuesday, December 03, 2013 4:31 AM
> To: Paul Berry
> Cc: waffle at lists.freedesktop.org; Shazia Rahman
> Subject: Re: [PATCH] cmake: Fix dependency on cmocka
> 
> On 12/02/2013 02:53 PM, Paul Berry wrote:
> > On 2 December 2013 14:46, Chad Versace <chad.versace at linux.intel.com>
> wrote:
> >
> >> This fixes an error in the Makefile-dependency of unittests,
> introduced
> >> in commit ad40427a864a7436953b319fbfdb2c04ccb7bdab.
> >>
> >>  From the perspective of Waffle's CMake, libcmocka.so is an
> *imported*
> >> library. In other words, it's a virtual target, represented by
> >> a '.PHONY' target in Unix Makefiles.
> >>
> >> To guarantee that libcmocka.so gets built, CMake must declare that
> the
> >> .PHONY 'cmocka' target depends on another .PHONY target, which does
> the
> >> actual building. Making 'cmocka' depend on a non-PHONY target
> doesn't
> >> work.
> >>
> >> Reported-by: Shazia Rahman <srahman at nvidia.com>
> >> Reported-by: Paul Berry <stereotype441 at gmail.com>
> >> Signed-off-by: Chad Versace <chad.versace at linux.intel.com>
> >>
> >
> > That fixes the problem for me, thanks!
> >
> > Tested-by: Paul Berry <stereotype441 at gmail.com>
> 
> Thanks, committed.
> 
> Hopefully this fixes Shazia's problem too.

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------