[waffle] [PATCH] cmake: wire up check and check-func with valgrind

Chad Versace chad.versace at linux.intel.com
Wed Sep 17 16:31:10 PDT 2014


On 09/10/2014 05:23 AM, Emil Velikov wrote:
> On 10/09/14 01:38, Emil Velikov wrote:
>> Add a valgrind-* counterpart for each target. Note that the
>> valgrind-check-func seems to leak like a sleeve yet I'm
>> suspecting that part of it is due to cmocka :P
>>
> Small update:
> 
> Thanks to Nils Gladitz we can drop the hard-coded paths by using a generator
> expression like below
> 
>> +            COMMAND ${VALGRIND_EXECUTABLE} ${CMAKE_BINARY_DIR}/tests/${unittest_name}
>                COMMAND ${VALGRIND_EXECUTABLE} $<TARGET_FILE:${unittest_name}>
> 
>> +        COMMAND ${VALGRIND_EXECUTABLE} ${CMAKE_BINARY_DIR}/tests/functional/gl_basic_test
>            COMMAND ${VALGRIND_EXECUTABLE} $<TARGET_FILE:gl_basic_test>

Without or without Nils' changes, this patch is
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>

I've already applied Nil's changes in my local branch. Do you mind
if I push with his changes added?




More information about the waffle mailing list