[waffle] [PATCH] cmake: wire up check and check-func with valgrind

[Emil Velikov]

On 18/09/14 00:31, Chad Versace wrote:
> On 09/10/2014 05:23 AM, Emil Velikov wrote:
>> On 10/09/14 01:38, Emil Velikov wrote:
>>> Add a valgrind-* counterpart for each target. Note that the
>>> valgrind-check-func seems to leak like a sleeve yet I'm
>>> suspecting that part of it is due to cmocka :P
>>>
>> Small update:
>>
>> Thanks to Nils Gladitz we can drop the hard-coded paths by using a generator
>> expression like below
>>
>>> +            COMMAND ${VALGRIND_EXECUTABLE} ${CMAKE_BINARY_DIR}/tests/${unittest_name}
>>                COMMAND ${VALGRIND_EXECUTABLE} $<TARGET_FILE:${unittest_name}>
>>
>>> +        COMMAND ${VALGRIND_EXECUTABLE} ${CMAKE_BINARY_DIR}/tests/functional/gl_basic_test
>>            COMMAND ${VALGRIND_EXECUTABLE} $<TARGET_FILE:gl_basic_test>
> 
> Without or without Nils' changes, this patch is
> Reviewed-by: Chad Versace <chad.versace at linux.intel.com>
> 
> I've already applied Nil's changes in my local branch. Do you mind
> if I push with his changes added?
> 
I would prefer if we go with Nils suggestion. Not sure if we want this in
master, although I'll leave that decision to you :)


-Emil

P.S. Nils, ngladitz on #cmake - the guy that helped our cleanup the cmocka build.

> 
> _______________________________________________
> waffle mailing list
> waffle at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/waffle
>