[waffle] [RFC PATCH 0/3] Silence compiler warnings

[Chad Versace]

On 01/28/2015 09:45 AM, Emil Velikov wrote:
> Hi all,
> 
> The following three patches silences -Wunused-parameter warnings 
> encountered on a Android 5 build.
> 
> Which prompted me - "How interesting is the build if we add -Wextra ?"
>  - ~60 -Wunused-parameter warnings remaining.
>  - 1 -Wsign-compare
>  - and 212 -Woverride-init
> 
> The last one we're attempting to silence, yet the argument used seems to 
> be clang specific (-Wno-initializer-overrides) and throws a warning.
> 
> Should we bother addressing those, or just leave -Wextra disabled ?
> 
> Cheers,
> Emil
> 
> P.S. That's enough waffle + android nit-picking for now. I'm going to 
> head over to drm and mesa :-)

Emil, this series is
Reviewed-by: Chad Versace <chad.versace at intel.com>

But! git-am barfs on your patches. Every patch in the email is base64 encoded,
and git can't read it. Could you resend with a git-friendly encoding?

About to -Wextra or not to -Wextra for Android, I prefer we don't do it.
I don't find -Wunused-parameter very useful. And some of Waffle's code
relies on -Woverride-init. But I think it does make sense to enable -Wsign-compare.
sense to -Wsign-compare.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 884 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/waffle/attachments/20150202/cad43816/attachment.sig>