[waffle] [RFC PATCH 0/3] Silence compiler warnings

[Emil Velikov]

On 2 February 2015 at 22:14, Chad Versace <chad.versace at intel.com> wrote:
> On 01/28/2015 09:45 AM, Emil Velikov wrote:
>> Hi all,
>>
>> The following three patches silences -Wunused-parameter warnings
>> encountered on a Android 5 build.
>>
>> Which prompted me - "How interesting is the build if we add -Wextra ?"
>>  - ~60 -Wunused-parameter warnings remaining.
>>  - 1 -Wsign-compare
>>  - and 212 -Woverride-init
>>
>> The last one we're attempting to silence, yet the argument used seems to
>> be clang specific (-Wno-initializer-overrides) and throws a warning.
>>
>> Should we bother addressing those, or just leave -Wextra disabled ?
>>
>> Cheers,
>> Emil
>>
>> P.S. That's enough waffle + android nit-picking for now. I'm going to
>> head over to drm and mesa :-)
>
> Emil, this series is
> Reviewed-by: Chad Versace <chad.versace at intel.com>
>
> But! git-am barfs on your patches. Every patch in the email is base64 encoded,
> and git can't read it. Could you resend with a git-friendly encoding?
>
Sorry about this Chad, I've edited some patches (git commit
--annotate) via nano. Perhaps I goofed up something.
Will resend in a second, and push them to a branch just in case.

> About to -Wextra or not to -Wextra for Android, I prefer we don't do it.
> I don't find -Wunused-parameter very useful. And some of Waffle's code
> relies on -Woverride-init. But I think it does make sense to enable -Wsign-compare.
> sense to -Wsign-compare.
>
Should be been clearer - the Android (5 as per android-x86 project)
enables -Wunused-parameter by default. This series makes things a bit
less painful - i.e. silences those warnings,

Wrt "adding -Wextra" I was thinking about the linux (cmake) build.
Point taken, I'll put only sign-compare, on the TODO list :-)

-Emil