[waffle] [PATCH] cgl: do not emit an error on dl_can_open

Emil Velikov emil.l.velikov at gmail.com
Thu Feb 12 03:13:22 PST 2015


According to the documentation and the linux backend one should not emit
an error but simply return true/false.

Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
---
 src/waffle/cgl/cgl_dl.m | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/waffle/cgl/cgl_dl.m b/src/waffle/cgl/cgl_dl.m
index 2d13067..764ecf0 100644
--- a/src/waffle/cgl/cgl_dl.m
+++ b/src/waffle/cgl/cgl_dl.m
@@ -77,8 +77,13 @@ cgl_dl_can_open(struct wcore_platform *wc_plat,
                 int32_t waffle_dl)
 {
     struct cgl_platform *plat = cgl_platform(wc_plat);
+    bool ok;
 
-    if (!cgl_dl_check_enum(waffle_dl))
+    WCORE_ERROR_DISABLED({
+        ok = cgl_dl_check_enum(waffle_dl);
+    });
+
+    if (!ok)
         return false;
 
     if (plat->dl_gl != NULL)
-- 
2.2.2



More information about the waffle mailing list