[waffle] [PATCH v3] nacl: add implementation for waffle_config_choose

Tapani tapani.palli at intel.com
Tue Feb 17 21:55:08 PST 2015


On 02/18/2015 01:44 AM, Emil Velikov wrote:
> On 16/02/15 06:49, Tapani Pälli wrote:
>> Patch fills attributes table suitable for Pepper API from
>> wcore_config_attrs passed by the application.
>>
>> v2: throw error on unsupported context type (Chad Versace)
>>      code cleanup, comment for max attribs (Emil Velikov)
>> v3: free memory if context type not supported (Emil Velikov)
>>
> Thanks Tapani.
>
> I'm starting to feel a bit guilty for nit-picking like an old bat,
> pardon if it came a bit too much.

Don't worry, this is *peanuts* compared to nit-picking happening at some 
other projects :) Thanks for the reviews!

> Fwiw feel free to add to patches 1-6
> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>
>
> Cheers,
> Emil
>



More information about the waffle mailing list