[waffle] [PATCH v3] nacl: add implementation for waffle_config_choose

[Chad Versace]

On 02/17/2015 09:55 PM, Tapani wrote:
> On 02/18/2015 01:44 AM, Emil Velikov wrote:
>> On 16/02/15 06:49, Tapani Pälli wrote:
>>> Patch fills attributes table suitable for Pepper API from
>>> wcore_config_attrs passed by the application.
>>>
>>> v2: throw error on unsupported context type (Chad Versace)
>>>      code cleanup, comment for max attribs (Emil Velikov)
>>> v3: free memory if context type not supported (Emil Velikov)
>>>
>> Thanks Tapani.
>>
>> I'm starting to feel a bit guilty for nit-picking like an old bat,
>> pardon if it came a bit too much.
> 
> Don't worry, this is *peanuts* compared to nit-picking happening at some other projects :) Thanks for the reviews!

So true :-/

>> Fwiw feel free to add to patches 1-6
>> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

Great! Now that everything has been reviewed by two sets of eyes,
and we have a plan for fixing the little bugs, I'll pull Tapani's patches
into master later today.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 884 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/waffle/attachments/20150220/edd4bb40/attachment.sig>