[waffle] [PATCH] wflinfo: find glGetStringi on both Mali and WGL

Chad Versace chad.versace at intel.com
Tue Jan 27 09:59:10 PST 2015


On 01/26/2015 03:25 PM, Frank Henigman wrote:
> Do the glGetStringi lookup after making context current so it works on WGL.
> Remove an incorrect glGetStringi lookup, which returned NULL on Mali.
> 
> Signed-off-by: Frank Henigman <fjhenigman at google.com>
> ---
> Not sure what happened but wflinfo is still broken on mali because of the glGetStringi madness.
> Chad put in a fix:
> https://github.com/waffle-gl/waffle/commit/0543d0d12aa16e0daf361937619998c8995fd6fc
> and ten days before that Emil had moved the offending waffle_get_proc_address("glGetStringi") down about 20 lines:
> https://github.com/waffle-gl/waffle/commit/6ae99a4701bd5117a182c2e555a0c0a2061254d3
> It looks like both changes to that line got in, because after Chad's change successfully sets the address the old, wrong line later sets it to null.
> 
>  src/utils/wflinfo.c | 40 +++++++++++++++++++---------------------
>  1 file changed, 19 insertions(+), 21 deletions(-)

LGTM
Reviewed-by: Chad Versace <chad.versace at intel.com>

This will land in maint-1.5 and master later today.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 884 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/waffle/attachments/20150127/f427fdd4/attachment.sig>


More information about the waffle mailing list