[waffle] [PATCH] wflinfo: find glGetStringi on both Mali and WGL

Emil Velikov emil.l.velikov at gmail.com
Tue Jan 27 10:09:44 PST 2015


On 26 January 2015 at 23:25, Frank Henigman <fjhenigman at google.com> wrote:
> Do the glGetStringi lookup after making context current so it works on WGL.
> Remove an incorrect glGetStringi lookup, which returned NULL on Mali.
>
> Signed-off-by: Frank Henigman <fjhenigman at google.com>
Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

> ---
> Not sure what happened but wflinfo is still broken on mali because of the glGetStringi madness.
> Chad put in a fix:
> https://github.com/waffle-gl/waffle/commit/0543d0d12aa16e0daf361937619998c8995fd6fc
> and ten days before that Emil had moved the offending waffle_get_proc_address("glGetStringi") down about 20 lines:
> https://github.com/waffle-gl/waffle/commit/6ae99a4701bd5117a182c2e555a0c0a2061254d3
> It looks like both changes to that line got in, because after Chad's change successfully sets the address the old, wrong line later sets it to null.
> Sorry but I'm not able to test on Windows.
>
The "offending" commit is based on top of the commit prior to the WGL
branch merge. So I'm guessing that either git did not notice the
change and/of Chad was tired as he pushed the Mali fix.

Frank I take it that Mali works with this change, whereas for Windows
I'm 99.99% certain it'll be fine.

Cheers,
Emil


More information about the waffle mailing list