[waffle] [PATCH 05/10] nacl: emit errors when things fail

[Tapani Pälli]

On 03/25/2015 03:59 PM, Emil Velikov wrote:
> On 25 March 2015 at 06:21, Tapani <tapani.palli at intel.com> wrote:
>> I don't quite agree with this change, IMO the behavior is fine as it matches
>> how other backends work. The 'gl' prefix is "internal detail", user should
>> not be trying to dlopen some other functions anyway?
>>
> I'm not 100% sure about your concern here - are you suggesting a
> change from WAFFLE_ERROR_UNKNOWN to WAFFLE_ERROR_INTERNAL, or that the
> user does not deserve to get any message on failure ? One could think
> about pushing the gl check further up to the waffle internal api but
> considering this is the only place waffle cares it's ok as is.

OK, I'm fine adding the error. It just first felt a bit strange case, 
this shouldn't really ever happen and error exposes details that might 
some day change. Purpose of the call is to query for functions only for 
the given API so anything else is out of scope and the poor (but maybe 
also evil) user knows it. For the patch;

Reviewed-by: Tapani Palli <tapani.palli at intel.com>

// Tapani