[Wayland-bugs] [Bug 68649] SIGSEGV in shell_surface_move

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=68649

Kristian Høgsberg <krh at bitplanet.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Kristian Høgsberg <krh at bitplanet.net> ---
...
> The troublesome code is in shell.c/shell_surface_move -- seat->touch is NULL
> which
> clearly causes a SEGV:
> 	} else if (seat->touch->grab_serial == serial) {
> 
> I don't have any touch devices. Should there be some extra check here?

There should indeed, thanks.  Committed to weston master (and will be in
1.2.2):

commit e1b655df922d1feb2409a1401c83041747645175
Author: Kristian Høgsberg <krh at bitplanet.net>
Date:   Wed Aug 28 23:16:20 2013 -0700

    shell: Make sure we have seat->pointer and seat->touch before dereferencing

    Either of these may not be available when we handle wl_shell_surface.move,
    and we need to not crash when that's the case.

    https://bugs.freedesktop.org/show_bug.cgi?id=68649

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20130829/aeb999fb/attachment-0001.html>