[Wayland-bugs] [Bug 697855] Implement DnD in wayland

[gtk+ (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=697855
  gtk+ | Backend: Wayland | 3.8.x

Matthias Clasen <mclasen> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #284210|none                        |reviewed
             status|                            |

--- Comment #27 from Matthias Clasen <mclasen at redhat.com> 2014-08-26 03:16:40 UTC ---
Review of attachment 284210:
 --> (https://bugzilla.gnome.org/review?bug=697855&attachment=284210)

::: gdk/wayland/gdkselection-wayland.c
@@ +16,3 @@
  */

+#define _GNU_SOURCE

No longer needed - instead just move the config.h include up first. We use
AC_USE_SYSTEM_EXTENSIONS in configure.ac now.

@@ +115,3 @@
+
+  buffer = g_new0 (SelectionBuffer, 1);
+  buffer->stream = stream;

You don't take a ref on stream here

@@ +147,3 @@
+
+  if (buffer_data->stream)
+    g_object_unref (buffer_data->stream);

...but you unref it here.

@@ +177,3 @@
+{
+  if (!g_list_find (buffer->requestors, requestor))
+    buffer->requestors = g_list_prepend (buffer->requestors, requestor);

Do you need to take a ref here ?

@@ +254,3 @@
+    }
+
+  return selection;

Might be nicer to tie this to the display singleton, and actually clean it up
when the display is closed.

@@ +265,3 @@
+
+  selection->targets = g_list_prepend (selection->targets,
+                                       gdk_atom_intern (type, FALSE));

Can this list have duplicates ? Would it be a problem ?

@@ +457,3 @@
+      else
+        {
+          pipe2 (pipe_fd, O_CLOEXEC);

Could use g_unix_open_pipe here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.