[Wayland-bugs] [Bug 697855] Implement DnD in wayland

[gtk+ (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=697855
  gtk+ | Backend: Wayland | 3.8.x

Matthias Clasen <mclasen> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #284211|none                        |reviewed
             status|                            |

--- Comment #28 from Matthias Clasen <mclasen at redhat.com> 2014-08-26 03:26:29 UTC ---
Review of attachment 284211:
 --> (https://bugzilla.gnome.org/review?bug=697855&attachment=284211)

::: gdk/wayland/gdkselection-wayland.c
@@ +389,3 @@
+      if (mode == GDK_PROP_MODE_APPEND)
+        g_array_append_vals (array, selection->stored_selection.data,
+                             selection->stored_selection.data_len - 1);

Isn't this the wrong way around ? if the mode is APPEND, you should append the
new data to the stored_selection.data. It looks like you are instead appending
the stored_selection.data to the new data.

@@ +617,3 @@
+
+      gdk_wayland_device_set_selection (device, NULL);
+      g_clear_pointer (&wayland_selection->clipboard_source,
wl_data_source_destroy);

Jasper pointed out in another review that he prefers protocol calls to not be
hidden as clear_pointer callbacks.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.