[Wayland-bugs] [Bug 74632] wl_shm_pool_resize crashes weston

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=74632

Pekka Paalanen <ppaalanen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|weston                      |wayland

--- Comment #1 from Pekka Paalanen <ppaalanen at gmail.com> ---
Yikes. Yes, the client behavior you describe is an application bug, in that it
is reusing/destroying the buffer's storage without waiting for a
wl_buffer.release, right? Also the client should destroy the wl_buffer before
invalidating its storage.

But this client bug also exposes a weston bug in that weston really should not
crash here.

Actually this needs to be fixed in libwayland-server, because the
wl_shm_pool_resize is handled there. I'd prefer to send a fatal error to the
client immediately when a resize attempts invalidate the storage of any
existing wl_buffer, rather than check on use. We may also want to add a note of
this in the protocol spec.

A simpler alternative would be to specify that resize must never make the size
smaller. I am unsure which one would be preferable.

Therefore I am changing the component to "wayland", on a quick glance I do not
see anything needing fixing in Weston code.

Thanks for reporting this.

(I'm only analyzing this one for now, not assigning it to myself.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20140207/e67b528f/attachment.html>