[Wayland-bugs] [Bug 744932] Wrong (ultra tiny/small) cursor size on HiDPI screen

[mutter (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=744932

--- Comment #31 from Owen Taylor <otaylor at redhat.com> ---
Review of attachment 301060:

Hmm, this deviates a lot from how I'd expect things to be organized. Use your
judgement whether you agree with me or not :-) If you want me to review things
as is without any reconceptualization of MetaCursorSprite , let me know, and
I'll do that.

::: src/backends/meta-cursor-renderer.c
@@ -103,3 @@
-      priv->current_rect.y = priv->current_y - hot_y;
-      priv->current_rect.width = cogl_texture_get_width (COGL_TEXTURE
(texture));
-      priv->current_rect.height = cogl_texture_get_height (COGL_TEXTURE
(texture));

I'd have expected the rectangle computations to stay here and the
MetaCursorSprite operation to be more like "here's the desired scale, what do
you have for me?"

::: src/frontends/wayland/meta-cursor-wayland.c
@@ +129,3 @@
+      image_scale = 1;
+      if (priv->monitor_scale != monitor->scale)
+        meta_cursor_sprite_load_from_theme (cursor_sprite, monitor->scale);

This is certainly not where I'd expect to find this code... in the pure
"frontend" conceptualization of MetaCursorSprite, a MetaCursorSpriteWayland has
nothing to do with themed cursors - a wayland cursor is one set by a Wayland
client.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20150410/c944205b/attachment-0001.html>