[Wayland-bugs] [Bug 744932] Wrong (ultra tiny/small) cursor size on HiDPI screen

[mutter (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=744932

Owen Taylor <otaylor at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #309532|none                        |needs-work
             status|                            |

--- Comment #96 from Owen Taylor <otaylor at redhat.com> ---
Review of attachment 309532:

s/drawed/drawn/.

Commit message needs more motivation - what is going wrong that causes this
patch to be needed?

::: src/wayland/meta-wayland-surface.c
@@ +550,3 @@
     case META_WAYLAND_SURFACE_ROLE_NONE:
+      wl_list_insert_list (&surface->frame_callback_list,
+                           &pending->frame_callback_list);

Needs a comment - like "since there is no role, we won't draw the window, so
save the frame callbacks for later".

::: src/wayland/meta-wayland-surface.h
@@ +116,3 @@
+   * commit sequence, such as when it has not yet been assigned a role.
+   */
+  struct wl_list frame_callback_list;

should be 'pending_frame_callbacks' or something - if I see
surface->frame_callback_list, I would have no expectation that it's a transient
thing that is used just in some cases.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20150824/00d8e8bc/attachment.html>