[Wayland-bugs] [Bug 759168] wayland: Implement DND icon hotspot API
gtk+ (GNOME Bugzilla)
bugzilla at gnome.org
Tue Dec 8 08:21:14 PST 2015
https://bugzilla.gnome.org/show_bug.cgi?id=759168
Matthias Clasen <mclasen at redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #316924|none |reviewed
status| |
--- Comment #3 from Matthias Clasen <mclasen at redhat.com> ---
Review of attachment 316924:
::: gdk/wayland/gdkdnd-wayland.c
@@ +51,3 @@
gdouble y;
+ gint prev_hot_x;
+ gint prev_hot_y;
I don't see the need to store these in the context. They can just be locals in
set_hot_spot
@@ +329,3 @@
+ .width = 1,
+ .height = 1,
+ },
This kind of on-the-fly struct looks a little out of style in the GTK+
codebase. Do we do this elsewhere in the Wayland backend ?
--
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20151208/e3437adf/attachment.html>
More information about the wayland-bugs
mailing list