[Wayland-bugs] [Bug 759161] wayland: dialog stacking without parents (RFC)

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=759161

--- Comment #11 from Olivier Fourdan <ofourdan at redhat.com> ---
(In reply to Matthias Clasen from comment #10)
> Review of attachment 316949 [details] [review]:
> 
> ::: gdk/wayland/gdkwindow-wayland.c
> @@ +713,3 @@
>  static void
> +gdk_wayland_window_sync_parent (GdkWindow *window,
> +                                GdkWindow *parent)
> 
> You add a parent argument here, but all callers pass NULL ?

Nope, not all.

The parent is used in gdk_wayland_window_update_dialogs() precisely when no
transient is set:

+      /* Update the parent relationship only for dialogs without transients */
+      if (!impl->transient_for)
+        gdk_wayland_window_sync_parent (w, window);

> @@ +1972,3 @@
>    impl->transient_for = parent;
>  
> +  gdk_wayland_window_sync_parent (window, NULL);
> 
> Did you mean to pass the parent in here ?

No, not here (although we could), there is no need as impl->transient_for is
set just above.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20151209/7da8dde3/attachment.html>