[Wayland-bugs] [Bug 735888] dnd drag cancellation animation missing

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=735888

Carlos Garnacho <carlosg at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #317072|none                        |reviewed
             status|                            |

--- Comment #9 from Carlos Garnacho <carlosg at gnome.org> ---
Review of attachment 317072:

::: gtk/gtkdnd.c
@@ +3202,3 @@

+  /* keep the icon_window alive until the (possible) drag cancel animation is
done */
+  g_object_set_data_full (G_OBJECT (info->context), "former-gtk-source-info",
info, (GDestroyNotify)gtk_drag_source_info_free);

Been thinking on this and can't figure out a better way tbh... we can't add a
post-animation vfunc to GdkDragContext because x11 is the only place we can
know that, and hooking the GtkDragSourceInfo to the icon_window widget being
destroyed relies on gdk knowing how to indirectly destroy the widget in the
first place.

That said, the GtkDragSourceInfo is already previously attached to the context
as dest_info_quark, we might as well set up a GDestroyNotify when creating the
source info and making gtk_drag_clear_source_info() steal the qdata.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20151210/ddd5e840/attachment.html>