[Wayland-bugs] [Bug 745289] wayland: do not use g_error() on connection errors

gtk+ (GNOME Bugzilla) bugzilla at gnome.org
Fri Feb 27 07:17:30 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=745289

Matthias Clasen <mclasen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #298092|none                        |reviewed
             status|                            |

--- Comment #1 from Matthias Clasen <mclasen at redhat.com> ---
Review of attachment 298092:

::: gdk/wayland/gdkeventsource.c
@@ +162,3 @@
     {
+      if (wl_display_dispatch (display_wayland->wl_display) < 0) {
+        g_printerr ("Error dispatching display: %s\n", g_strerror (errno));

As mentioned on irc: Probably better to say "Wayland display" here.

@@ +168,3 @@

+  if (source->pfd.revents & (G_IO_ERR | G_IO_HUP)) {
+    g_printerr ("Lost connection to wayland compositor\n");

And "Wayland compositor" here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20150227/d7f6580f/attachment.html>


More information about the wayland-bugs mailing list