[Wayland-bugs] [Bug 751414] File descriptor leak in gdk_wayland_selection_request_target()

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751414

--- Comment #6 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Unfortunately your patch is wrong too; in my tests, GTK+ with your patch (which
went into master this morning) leaks roughly half as many fds as it did
previously, whereas my patch plugs the leak completely. (But don't apply my
patch, it probably breaks things worse, I need to study this more still. :)

We should not close() the fd manually because we pass TRUE as the second
argument to g_unix_output_stream_new(). So actually, this may not be a leak per
se, but a protocol flaw. Perhaps GTK+ will eventually free the fds if the other
client ever reads the data from the pipe (which my attacking client does not
ever do).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20150624/891a17df/attachment.html>