[Wayland-bugs] [Bug 719819] Wayland backend depends on ordering of globals in the display server

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=719819

Matthias Clasen <mclasen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #303510|none                        |reviewed
             status|                            |

--- Comment #5 from Matthias Clasen <mclasen at redhat.com> ---
Review of attachment 303510:

::: gdk/wayland/gdkdisplay-wayland.c
@@ +366,3 @@
+  if (handled)
+    g_hash_table_insert (display_wayland->known_globals,
+                         GUINT_TO_POINTER (id), g_strdup (interface));

Given that the one use for this hash table is to look up globals by their
interface, wouldn't it make more sense to flip this around, and make the
interface name the key ? Then you can actually use the hash table as it was
meant to be used: by doing lookups, instead of iterating over it...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20150518/c7077db3/attachment.html>