[Wayland-bugs] [Bug 719819] Wayland backend depends on ordering of globals in the display server

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=719819

--- Comment #6 from Jonas Ådahl <jadahl at gmail.com> ---
(In reply to Matthias Clasen from comment #5)
> Review of attachment 303510 [details] [review]:
> 
> ::: gdk/wayland/gdkdisplay-wayland.c
> @@ +366,3 @@
> +  if (handled)
> +    g_hash_table_insert (display_wayland->known_globals,
> +                         GUINT_TO_POINTER (id), g_strdup (interface));
> 
> Given that the one use for this hash table is to look up globals by their
> interface, wouldn't it make more sense to flip this around, and make the
> interface name the key ? Then you can actually use the hash table as it was
> meant to be used: by doing lookups, instead of iterating over it...

There may be more than one global per interface name (multiple seats, multiple
outputs), so we wouldn't know how to delete if we didn't use the id as key. We
could, I suppose, change it to ignore that globals may be removed, since we
only use this during initialization anyway.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20150518/e90ec131/attachment.html>