[Wayland-bugs] [Bug 757530] GtkWindow reacts on maximize action even if it is fixed-width

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=757530

--- Comment #10 from Olivier Fourdan <ofourdan at redhat.com> ---
(In reply to Matthias Clasen from comment #8)
> Review of attachment 314813 [details] [review]:
> 
> ::: gdk/wayland/gdkwindow-wayland.c
> @@ +2057,3 @@
> +                             &allowed_width,
> +                             &allowed_height);
> +
> 
> Hmm, are you sure this can work ? Afaik, the window geometry (at least the
> window position) is largely fantasy, under wayland.

Good point. Although we don't check for the positioning ourselves here, I
reckon gdk_screen_get_monitor_at_window() does for us but I haven't check if
that would actually work with a multi-monitor setup on Wayland, indeed.

> And the margin you are
> using here is the large non-maximized margin, whereas an actually maximized
> window has no margin at all...

Yes, the idea was to make sure the actual window content would fit the
resulting area, either by removing the margins from the window or adding them
to the expected size.

Anyhow, I added this patch for the sake of completion, it's not required to fix
this current issue, if we get attachment 314814 and attachment 314815 into gtk+
this is less likely to happen.

Of course, if an app calls gtk_window_maximize() on a window which is not
resizable (or not resizable enough) it will still fail on Wayland without
attachment 314813 but it's a slightly less probable scenario (and one could
argue that the app itself sets its window constrains so if the app tries to
maximize a window while not allowing for it using constrains, it would be a bug
in the app itself).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20151105/57815c6e/attachment-0001.html>