[Wayland-bugs] [Bug 757530] GtkWindow reacts on maximize action even if it is fixed-width

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=757530

--- Comment #11 from Olivier Fourdan <ofourdan at redhat.com> ---
(In reply to Jonas Ådahl from comment #9)
> (In reply to Matthias Clasen from comment #7)
> > Review of attachment 314814 [details] [review] [review]:
> > 
> > ::: gdk/wayland/gdkwindow-wayland.c
> > @@ +1033,1 @@
> >  }
> > 
> > Is it ok to not ack configure ?
> 
> Yes. According to the current spec it is Ok to drop all configure requests
> except the last one, but since there might already be a configure request on
> the wire when the client drops all but the last and acks that, I don't see
> how the server can disallow that ack anyway.

Beside, if we ack the request without applying the changes to the state/size,
the Wayland compositor reckons the configure was successful and will move the
window to the top left corner (as it would if it was actually maximized), which
is not what we want here as we didn't allow for maximization.

So I reckon we shouldn't ack the request if we didn't apply it.

The spec reads:

        When a configure event is received, if a client commits the
        surface in response to the configure event, then the client
        must make an ack_configure request sometime before the commit
        request, passing along the serial of the configure event.

        For instance, the compositor might use this information to move
        a surface to the top left only when the client has drawn itself
        for the maximized or fullscreen state.

        If the client receives multiple configure events before it
        can respond to one, it only has to ack the last configure event.

        A client is not required to commit immediately after sending
        an ack_configure request - it may even ack_configure several times
        before its next surface commit.

        The compositor expects that the most recently received
        ack_configure request at the time of a commit indicates which
        configure event the client is responding to.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20151105/dc098016/attachment.html>