[Wayland-bugs] [Bug 756780] wayland: Fix GtkTreeView's search window

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=756780

Matthias Clasen <mclasen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #313621|none                        |reviewed
             status|                            |

--- Comment #17 from Matthias Clasen <mclasen at redhat.com> ---
Review of attachment 313621:

::: gtk/gtktreeview.c
@@ +6035,2 @@
       gtk_tree_view_ensure_interactive_directory (tree_view);


The fixup I attached separately should probably be squashed here.

@@ +11168,3 @@
   gtk_window_set_modal (GTK_WINDOW (tree_view->priv->search_window), TRUE);
+  gtk_window_set_transient_for (GTK_WINDOW (tree_view->priv->search_window),
+                                GTK_WINDOW (toplevel));

Is this related to the key event handling changes ? looks unrelated to me.

@@ +11279,3 @@
+  /* Grab focus without selecting all the text. */
+  _gtk_entry_grab_focus (GTK_ENTRY (tree_view->priv->search_entry), FALSE);
+

We have public GtkEntry api for this now: 
gtk_entry_grab_focus_without_selecting().
Might as well use that here, to reduce our reliance on private APIs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20151021/98dcb850/attachment-0001.html>