[Wayland-bugs] [Bug 754631] test-integration example not working out-of-the-box (1 patch attached)

[gtk-mac-integration (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754631

John Ralls <jralls at ceridwen.fremont.ca.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #310743|none                        |needs-work
             status|                            |

--- Comment #2 from John Ralls <jralls at ceridwen.fremont.ca.us> ---
Comment on attachment 310743
  --> https://bugzilla.gnome.org/attachment.cgi?id=310743
logs icon change and set it at boot

In the first hunk, what's the point of exit(1), and having called exit() why
any code after that?

You're leaking pixbufs. Since every press of the button loads a new pixbuf you
need to gdk_pixbuf_unref() the old one first... which you can't do because you
don't have a pointer to it because you made it local.

BTW, declaring variables in the middle of functions is a C11 feature, and Gtk+
needs to support C98.

Calling a callback function outside of a signal handler is bad form.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20150906/3cdb8791/attachment-0001.html>