[Wayland-bugs] [Bug 744932] Wrong (ultra tiny/small) cursor size on HiDPI screen

[mutter (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=744932

Owen Taylor <otaylor at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #309854|none                        |reviewed
             status|                            |

--- Comment #143 from Owen Taylor <otaylor at redhat.com> ---
Review of attachment 309854:

::: src/wayland/meta-wayland-surface.c
@@ +566,3 @@
+       *  - Go through the surface actors frame callback list until some time
after
+       *    it has been mapped so can avoid wasting buffers when the window is
+       *    hidden.

I'd like for us to say say:

 /* For Xwayland windows, throttling frames when the window isn't
  * actually drawn is less useful, because Xwayland still has to do
  * the drawing sent from the application - the throttling would only
  * be of sending us damage messages, so we simplify and send frame callbacks
  * after the next paint of the screen, whether the window was drawn
  * or not.
  * 
  * Currently in *some* cases we also seem to take a few frames before
  * we draw the window, for not completely understood reasons, and in
  * that case, not thottling frame callbacks to drawing has the
  * happy side effect that we avoid showing the user the initial black
  * frame from when the window is mapped empty.
  */

I can't find anything the code that intentionally tries to only show Xwayland
windows on the second frame, and when I add printfs, I don't see this behavior
- for me the first commit seems to be drawn with an already shown window.
Reading the code looks like to me that Xwayland windows are shown only based on
X traffic, without regard to wayland.

I suppose there perhaps is some sequence of, depending on the ordering of:

 receiving the WL_SURFACE_ID message 
 receiving the MapRequest/MapNotify message
 the commit messages

where things occur as you've noted, but I can't work out what is, and it
definitely doesn't seem intentional or reliable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20150910/f612ab7a/attachment.html>