[Wayland-bugs] [Bug 769402] regression in menu positioning on wayland

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769402

--- Comment #10 from William Hua <william at attente.ca> ---
Review of attachment 332693:

Thanks, just a couple questions, but these patches do fix the problem.

I'm still a bit hesitant to alter the default implementation for the sake of
the Wayland backend, which will have its own implementation at some point. But
if it still needs a lot of work, we can do it to fix the regression. I didn't
see any problems with this patch under X11 or Mir.

::: gdk/gdkwindowimpl.c
@@ +187,3 @@
+    {
+      if (_gdk_window_is_toplevel (window))
+{

Is this needed if we already know window->window_type == GDK_WINDOW_CHILD?

@@ +191,3 @@
+      gdk_window_coords_to_parent (window, xf, yf, &xf, &yf);
+
+  gdouble yf = y;

Should we use gdk_window_get_effective_parent (window) instead?

The docs for gdk_window_coords_to_parent () say that for off-screen windows, it
converts to the window's embedder instead.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20160805/b6525229/attachment.html>