[Wayland-bugs] [Bug 769835] On Wayland, application containing GtkGLArea stops responding if it's not on current workspace

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769835

Emmanuele Bassi (:ebassi) <ebassi at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #342424|none                        |needs-work
             status|                            |

--- Comment #20 from Emmanuele Bassi (:ebassi) <ebassi at gmail.com> ---
Review of attachment 342424:

Looks definitely better.

::: gdk/wayland/gdkglcontext-wayland.c
@@ +472,3 @@
+                           EGL_MIN_SWAP_INTERVAL,
+                           &display_wayland->egl_min_swap_interval))
+    return NULL;

You should set the GError if you return NULL here.

Something like:

  if (!eglGetConfigAttrib (...))
    {
      g_set_error_literal (error, GDK_GL_ERROR, GDK_GL_ERROR_NOT_AVAILABLE,
                           "Could not retrieve the minimum swap interval");
      return NULL;
    }

But maybe we should move this check inside find_eglconfig_for_window().

@@ +552,3 @@
+    eglSwapInterval (display_wayland->egl_display, 0);
+  else
+    g_warning ("Can't disable GL swap interval");

I'd probably use g_debug(), not a warning.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20161223/e391b1ce/attachment.html>