[Wayland-bugs] [Bug 760213] wayland: gdk_seat_grab() set cursor not resilient

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760213

Olivier Fourdan <ofourdan at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #318320|reviewed                    |none
             status|                            |
 Attachment #318320|0                           |1
        is obsolete|                            |

--- Comment #3 from Olivier Fourdan <ofourdan at redhat.com> ---
Created attachment 318485
  --> https://bugzilla.gnome.org/attachment.cgi?id=318485&action=edit
[PATCH v2] wayland: Update parent of dialogs without transient

(In reply to Matthias Clasen from comment #2)
> Review of attachment 318320 [details] [review]:
> 
> ::: gdk/wayland/gdkdevice-wayland.c
> @@ +2561,2 @@
>        wayland_seat->pointer_grab_window = NULL;
> +      _gdk_display_set_window_under_pointer (display,
> wayland_seat->master_pointer, window);
> 
> Calling set_window_under_pointer here seems wrong - the window may not be
> under the pointer at all at this point.

Right, what we want is to update toe cursor to whatever is relevant for the
window under the cursor.

> And as Carlos points out,

Not sure I followed here, where did Carlos pointed that out, was it on irc?

> this should already be happening in switch_to_pointer_grab.

Thing is, we "block" the cursor change while we have a grab, so we need to
update the cursor again after the grab is released.

Is it better to use gdk_wayland_device_update_window_cursor() for this purpose
instead of _gdk_display_set_window_under_pointer() here? (updated patch)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20160108/ea5ec373/attachment.html>