[Wayland-bugs] [Bug 764180] Dragging from fullscreen title to normal mode always places window at the left edge of the screen

mutter (GNOME Bugzilla) bugzilla at gnome.org
Mon Jun 13 15:16:55 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=764180

Rui Matos <tiagomatos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329688|none                        |accepted-commit_now
             status|                            |

--- Comment #9 from Rui Matos <tiagomatos at gmail.com> ---
Review of attachment 329688:

looks good

::: src/wayland/meta-window-wayland.c
@@ +311,3 @@
       if (new_x != window->rect.x || new_y != window->rect.y)
         {
+          *result |= META_MOVE_RESIZE_RESULT_MOVED;

At first I was worried because this will make us emit
MetaWindow::position-changed when the window hasn't actually moved yet. But,
consumers of that signal have to query the position anyway so they're still
going to see the old position which shouldn't cause any issues.

Any other solution would have to be updating display->grab_anchor_window_pos
later when we no longer know about the unmaximize() call so we'd need more
state to track it for no added benefit.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20160613/e4a48b9a/attachment.html>


More information about the wayland-bugs mailing list