[Wayland-bugs] [Bug 768177] CLIPBOARD target request after PRIMARY request times out. GDK_SELECTION_NOTIFY has wrong selection id

gtk+ (GNOME Bugzilla) bugzilla at gnome.org
Thu Jun 30 01:45:16 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=768177

Jonas Ådahl <jadahl at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330600|none                        |accepted-commit_now
             status|                            |

--- Comment #4 from Jonas Ådahl <jadahl at gmail.com> ---
Review of attachment 330600:

As far as I can tell, this looks correct to me (with one minor nit).

::: gdk/wayland/gdkselection-wayland.c
@@ +99,3 @@
 {
   /* Destination-side data */
+  SelectionData selections[3];

nit: Could just as well now add a ATOM_LAST or N_ATOMS to the enum, and use
that instead of the 3s? Makes it more obvious what is in the arrays as well.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20160630/275bd092/attachment.html>


More information about the wayland-bugs mailing list