[Wayland-bugs] [Bug 763852] gdk/wayland: event source is not multi-thread aware

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763852

Jonas Ådahl <jadahl at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #324232|none                        |needs-work
             status|                            |

--- Comment #2 from Jonas Ådahl <jadahl at gmail.com> ---
Review of attachment 324232:

Indeed. The patch looks mostly good, except the inline comment and that you
don't cancel on finalize, if we ended up having prepared and not dispatched.

FWIW, the wl_display_dispatch(_queue)() API is multi-thread safe if used
correctly (i.e. don't mix poll() and dispatch() more or less), so should
probably update the commit message to reflect that.

::: gdk/wayland/gdkeventsource.c
@@ +63,3 @@
+        g_error ("Error dispatching display: %s", g_strerror (errno));
+    }
+

You should set source->reading to TRUE here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20160318/6a4d82ad/attachment.html>