[Wayland-bugs] [Bug 763852] gdk/wayland: event source is not multi-thread aware

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763852

--- Comment #3 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Created attachment 324237
  --> https://bugzilla.gnome.org/attachment.cgi?id=324237&action=edit
gdk/wayland: use the multi-thread safe wayland dispatching API

(In reply to Jonas Ådahl from comment #2)
> Indeed. The patch looks mostly good, except the inline comment and that you
> don't cancel on finalize, if we ended up having prepared and not dispatched.

The reentrant thing?  I've changed it to mention balancing prepare/cancel/read
instead which makes more sense.

cancel on finalize() is fixed.

> FWIW, the wl_display_dispatch(_queue)() API is multi-thread safe if used
> correctly (i.e. don't mix poll() and dispatch() more or less), so should
> probably update the commit message to reflect that.

Something like this?

> ::: gdk/wayland/gdkeventsource.c
> @@ +63,3 @@
> +        g_error ("Error dispatching display: %s", g_strerror (errno));
> +    }
> +
> 
> You should set source->reading to TRUE here.

Fixed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20160318/5dd8afd6/attachment.html>