[Wayland-bugs] [Bug 763852] gdk/wayland: event source is not multi-thread aware

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763852

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #325118|needs-work                  |none
             status|                            |
 Attachment #325118|0                           |1
        is obsolete|                            |

--- Comment #12 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Created attachment 327362
  --> https://bugzilla.gnome.org/attachment.cgi?id=327362&action=edit
gdk/wayland: use the multi-thread safe wayland dispatching API

(In reply to Jonas Ådahl from comment #11)
> Review of attachment 325118 [details] [review]:
> 
> I think it looks fine except for one detail which I haven't managed to find
> clear documentation about.
> 
> ::: gdk/wayland/gdkeventsource.c
> @@ +56,3 @@
> +   * wl_display_read_events() or wl_display_cancel_read()
> +   * (in gdk_event_source_check() */
> +  g_assert (source->reading == FALSE);
> 
> I can't find any documentation saying a non-mainloop caller may never
> prepare() only once before calling check(), so I think this assert is a bit
> dangerous. In other words, I think we should maybe change this assert to if
> (source->reading) return FALSE;

Now uses if (source->reading) return FALSE;

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20160506/d788a591/attachment.html>